Re: [PATCH] isofs: release zisofs block pointer buffer head

[Jan Kara]

On Tue 21-07-26 17:11:52, Yichong Chen wrote:
> zisofs_fill_pages() reads the compressed block pointer table.
> 
> The error paths release the current buffer_head.
> 
> The loop also releases the old buffer_head when it advances.
> 
> However, the success path leaves the last buffer_head referenced.
> 
> Release it before returning success.
> 
> Fixes: 59bc055211b8 ("zisofs: Implement reading of compressed files when PAGE_CACHE_SIZE > compress block size")
> Signed-off-by: Yichong Chen <chenyichong@xxxxxxxxxxxxx>

Thanks! I've added the patch to my tree.

								Honza

> ---
>  fs/isofs/compress.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/isofs/compress.c b/fs/isofs/compress.c
> index 3fda92358e22..f9869d62b850 100644
> --- a/fs/isofs/compress.c
> +++ b/fs/isofs/compress.c
> @@ -293,6 +293,7 @@ static int zisofs_fill_pages(struct inode *inode, int full_page, int pcount,
>  		memzero_page(*pages, poffset, PAGE_SIZE - poffset);
>  		SetPageUptodate(*pages);
>  	}
> +	brelse(bh);
>  	return 0;
>  }
>  
> -- 
> 2.51.0
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR