Re: [PATCH 1/6] dt-bindings: PCI: toshiba,tc9563: Restrict Tx Amplitude, DFE and N_FTS to USP, DSP1 and DSP2

[Alex Elder]

On 7/25/26 3:59 AM, Manivannan Sadhasivam via B4 Relay wrote:
> From: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxxxxxxxx>
>
> TC9563 switch allows configuring Tx Amplitude, DFE and N_FTS settings only
> to USP, DSP1 and DSP2 ports. These settings don't apply to DSP3 and also
> the integrated Ethernet MAC Endpoint.

s/and also the/nor its/

Also I don't know if there is only one Ethernet MAC here, but
the TC9564 has two, so maybe make "MAC Endpoint" plural.

> So restrict these properties and also move the
> 'toshiba,tx-amplitude-microvolt' property to DSP2 in the example to conform
> to the binding.
>
> Fixes: 26f3ac884835 ("dt-bindings: PCI: Add binding for Toshiba TC9563 PCIe switch")
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxxxxxxxx>

I have some other questions with implied suggestions below, but
this looks good to me.

Acked-by: Alex Elder <elder@xxxxxxxxxxxx>

> ---
>   .../devicetree/bindings/pci/toshiba,tc9563.yaml     | 21 ++++++++++++++++++---
>   1 file changed, 18 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml b/Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml
> index b3ad05d90201..f084830c6d0c 100644
> --- a/Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml
> +++ b/Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml
> @@ -54,7 +54,7 @@ properties:
>             - description: I2C slave address
>   
>   patternProperties:
> -  "^pcie@[1-3],0$":
> +  "^pcie@[1-2],0$":
>       description:
>         child nodes describing the internal downstream ports of
>         the tc9563 switch.

Can you offer any explanation about why the settings apply to these
two downstream ports but not the third?  (I think it's because the
third has a different type of link to the endpoint.)

> @@ -64,6 +64,21 @@ patternProperties:
>         - $ref: /schemas/pci/pci-pci-bridge.yaml#
>       unevaluatedProperties: false
>   
> +  "^pcie@[3],0$":

Can this just be "^pcie@3,0$"?

Is there any need to define "^pcie@3,1" for the second PCI function?

> +    description:
> +      child node describing the internal downstream port connected to the
> +      integrated Ethernet MAC endpoint of the tc9563 switch.
> +    type: object
> +    $ref: /schemas/pci/pci-pci-bridge.yaml#
> +    properties:
> +      n-fts: false
> +    patternProperties:
> +      "^ethernet@0,[0-1]$":
> +        type: object
> +        properties:
> +          n-fts: false
> +    unevaluatedProperties: false
> +
>   $defs:
>     tc9563-node:
>       type: object
> @@ -154,6 +169,8 @@ examples:
>                       device_type = "pci";
>                       ranges;
>                       bus-range = <0x04 0xff>;
> +
> +                    toshiba,tx-amplitude-microvolt = <10>;
>                   };
>   
>                   pcie@3,0 {
> @@ -165,8 +182,6 @@ examples:
>                       ranges;
>                       bus-range = <0x05 0xff>;
>   
> -                    toshiba,tx-amplitude-microvolt = <10>;
> -
>                       ethernet@0,0 {
>                           reg = <0x50000 0x0 0x0 0x0 0x0>;
>                       };