Re: [PATCH net-next v12 2/8] hinic3: Fix loose success check in rx buffer filling

[Mohsin Bashir]

On 7/26/26 11:54 PM, Fan Gong wrote:
>    Tightens the success criterion for hinic3_rx_fill_buffers() in
> hinic3_configure_rxqs().
>
> Co-developed-by: Wu Di <wudi234@xxxxxxxxxx>
> Signed-off-by: Wu Di <wudi234@xxxxxxxxxx>
> Co-developed-by: Teng Peisen <tengpeisen@xxxxxxxxxx>
> Signed-off-by: Teng Peisen <tengpeisen@xxxxxxxxxx>
> Signed-off-by: Fan Gong <gongfan1@xxxxxxxxxx>
> ---
>   drivers/net/ethernet/huawei/hinic3/hinic3_rx.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c b/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c
> index 309ab5901379..389b1c2158be 100644
> --- a/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c
> +++ b/drivers/net/ethernet/huawei/hinic3/hinic3_rx.c
> @@ -541,7 +541,7 @@ int hinic3_configure_rxqs(struct net_device *netdev, u16 num_rq,
>   		rq_associate_cqes(rxq);
>   
>   		pkts = hinic3_rx_fill_buffers(rxq);
> -		if (!pkts) {
> +		if (pkts < rxq->q_mask) {
>   			netdev_err(netdev, "Failed to fill Rx buffer\n");
>   			return -ENOMEM;
>   		}

Given the subject, curious if a partially populated ring result in any 
functional failure? if so, then perhaps failure mode can be explained 
and this specific change be sent to net tree?