Re: [PATCH v8 1/2] firmware: stratix10-svc: add async HWMON read commands and register socfpga-hwmon device

[Guenter Roeck]

On 7/27/26 10:02, Dinh Nguyen wrote:
> Hi Guenter,
>
> On 7/23/26 01:02, tze.yee.ng@xxxxxxxxxx wrote:
> > From: Tze Yee Ng <tze.yee.ng@xxxxxxxxxx>
> >
> > Add asynchronous Stratix 10 service layer support for hardware monitor
> > temperature and voltage read commands in stratix10_svc_async_send() and
> > stratix10_svc_async_prepare_response().
> >
> > Register a socfpga-hwmon platform device from the service layer driver
> > when hardware monitor support is enabled, similar to the RSU device.
> >
> > Signed-off-by: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@xxxxxxxxxx>
> > Signed-off-by: Tze Yee Ng <tze.yee.ng@xxxxxxxxxx>
> > ---
> I've been taking these patches through Greg KH's char-misc tree. I'll wait on your feedback on patch 2 to take this patch.
If with "your" you refer to me - I can not determine if Sashiko's feedback
on the second patch is correct or not. To me it sounds like real problems,
but then I don't know the code well enough to be sure, and I don't have the
time to analyze it myself. So you won't get any feedback from me unless
someone declares that Sashiko's feedback can be ignored.

Thanks,
Guenter