Re: [PATCH 1/2] regulator: fp9931: Fix VPOS/VNEG voltage selector table

From: Andreas Kemnade

Date: Mon Jul 27 2026 - 16:07:10 EST


On Tue, 21 Jul 2026 17:59:58 +0800
robby.cai@xxxxxxxxxxx wrote:

> From: Robby Cai <robby.cai@xxxxxxx>
>
> The VPOSNEG_table[] mapping does not match the FP9931/JD9930
> datasheet.
>
> The datasheet defines the VPOS/VNEG voltage mapping as:
>
> 00h-04h -> 7.04V (-7.04V)
> 05h -> 7.26V (-7.26V)
> 06h -> 7.49V (-7.49V)
> ...
> 28h-3Fh -> 15.06V (-15.06V)
>
> However, the current table maps selector 0x05 to 7.04V instead of
> 7.26V, causing all subsequent entries to be shifted by one position.
>
> Update VPOSNEG_table[] to match the documented register encoding.
>
> Fixes: 12d821bd13d4 ("regulator: Add FP9931/JD9930 driver")
> Signed-off-by: Robby Cai <robby.cai@xxxxxxx>

Reviewed-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>