Re: [net,1/2] net: openvswitch: fix skb leak on flow key update failure during recirculation

[Aaron Conole]

Ilya Maximets <i.maximets@xxxxxxx> writes:

> do_execute_actions() returns right away when execute_recirc() fails on
> the last action as it assumes this function always takes ownership of
> the skb when 'last' is true.  But when the flow key update fails, the
> function doesn't free the skb and it ends up leaked.
> 
> This is a very unlikely scenario as it requires the packet to become
> unparseable by applying a set of actions on a previously parseable skb,
> but should be fixed nevertheless.
> 
> Reported by Sashiko.
> 
> Fixes: 971427f353f3 ("openvswitch: Add recirc and hash action.")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Ilya Maximets <i.maximets@xxxxxxx>
> ---
>  net/openvswitch/actions.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)

Reviewed-by: Aaron Conole <aconole@xxxxxxxxxx>