Re: [PATCH v6 05/22] include: trace: Add Telemetry trace events

[Jonathan Cameron]

On Fri, 24 Jul 2026 15:44:13 +0100
Cristian Marussi <cristian.marussi@xxxxxxx> wrote:

> Add custom traces to report Telemetry failed accesses and to report when DE
> values are updated internally after a notification is processed.
> 
> Signed-off-by: Cristian Marussi <cristian.marussi@xxxxxxx>
> ---
>  include/trace/events/scmi.h | 48 ++++++++++++++++++++++++++++++++++++-
>  1 file changed, 47 insertions(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/scmi.h b/include/trace/events/scmi.h
> index 703b7bb68e44..b70b26e467b8 100644
> --- a/include/trace/events/scmi.h
> +++ b/include/trace/events/scmi.h

> +
> +TRACE_EVENT(scmi_tlm_collect,
> +	TP_PROTO(u64 ts, u64 de_id, u64 value, unsigned char *tag),
> +	TP_ARGS(ts, de_id, value, tag),
> +
> +	TP_STRUCT__entry(
> +		__field(u64, ts)
> +		__field(u64, de_id)
> +		__field(u64, value)
> +		__array(char, tag, TRACE_SCMI_TLM_MAX_TAG_LEN)
> +	),
> +
> +	TP_fast_assign(
> +		__entry->ts = ts;
> +		__entry->de_id = de_id;
> +		__entry->value = value;
> +		strscpy(__entry->tag, tag, TRACE_SCMI_TLM_MAX_TAG_LEN);
> +	),
> +
> +	TP_printk("ts=%llu  de_id=0x%04llX  value=%016llu [%s]",

Why the double spaces? I was thinking this must be a local style thing but it doesn't
seem to be.

> +		  __entry->ts, __entry->de_id, __entry->value, __entry->tag)
> +);
> +