Re: [PATCH] greybus: audio_manager: fix sysfs_emit newline and const warnings

From: Greg KH

Date: Tue Jul 28 2026 - 03:22:12 EST


On Sat, Jul 25, 2026 at 06:45:45AM -0700, Shivesh wrote:
> >From 5e0bcb4920bcb9e0ef6c03a91730fe45f643f3a4 Mon Sep 17 00:00:00 2001
> From: Shivesh <shivesh@xxxxxxxxxxx>
> Date: Sat, 25 Jul 2026 13:44:36 +0000
> Subject: [PATCH] greybus: audio_manager: fix sysfs_emit newline and const
> warnings
>
> Add terminating newlines to sysfs_emit() format strings as required
> by the kernel sysfs convention. Also make envp[] array const to fix
> checkpatch warning about char* array declaration.
>
> Signed-off-by: Shivesh <chanelshivesh@xxxxxxxxx>
> Signed-off-by: Shivesh <shivesh@xxxxxxxxxxx>

Something went really wrong here, why sign off on this twice with
different email addresses?

Also, look in the archives for all the times that this same change has
been rejected.

thanks,

greg k-h