Re: [PATCH] staging: rtl8723bs: remove unnecessary braces
From: Greg KH
Date: Tue Jul 28 2026 - 03:48:02 EST
On Sun, Jul 26, 2026 at 04:23:19PM +0700, Dang Vu Duc Hien wrote:
> Fix the checkpatch.pl warning:
> "WARNING: braces {} are not necessary for single statement blocks"
> in rtw_wlan_util.c.
>
> The if-statement only contains one line of code. Remove the redundant
> pair of braces to comply with the kernel coding style.
>
> Signed-off-by: Dang Vu Duc Hien <dvdh12707@xxxxxxxxx>
> ---
> drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
> index a4de53872..f107304eb 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
> @@ -256,9 +256,8 @@ inline void rtw_set_oper_ch(struct adapter *adapter, u8 ch)
> {
> struct dvobj_priv *dvobj = adapter_to_dvobj(adapter);
>
> - if (dvobj->oper_channel != ch) {
> + if (dvobj->oper_channel != ch)
> dvobj->on_oper_ch_time = jiffies;
> - }
>
> dvobj->oper_channel = ch;
> }
> --
> 2.54.0
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- Your patch did not apply to any known trees that Greg is in control
of. Possibly this is because you made it against Linus's tree, not
the linux-next tree, which is where all of the development for the
next version of the kernel is at. Please refresh your patch against
the linux-next tree, or even better yet, the development tree
specified in the MAINTAINERS file for the subsystem you are submitting
a patch for, and resend it.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot