Re: [PATCH] media: ipu3: fix line ending with '(' in atomic_inc_return call

From: Sakari Ailus

Date: Tue Jul 28 2026 - 04:35:36 EST


Hi Shivesh,

Please fix your patch submission process (no attachments). The easy way is
to use git send-email.

On Sat, Jul 25, 2026 at 06:20:12AM -0700, Shivesh wrote:
> From c753198ad726500786ba04d66d531db4c11e2b03 Mon Sep 17 00:00:00 2001
> From: Shivesh <shivesh@xxxxxxxxxxx>
> Date: Sat, 25 Jul 2026 13:18:59 +0000
> Subject: [PATCH] media: ipu3: fix line ending with '(' in atomic_inc_return
> call
>
> Move the atomic_inc_return() argument to the same line as the
> function call to fix checkpatch 'Lines should not end with a ('
> warning.
>
> Signed-off-by: Shivesh <chanelshivesh@xxxxxxxxx>
> Signed-off-by: Shivesh <shivesh@xxxxxxxxxxx>

Why two e-mail addresses? The latter isn't valid either.

The change itself seems fine.

> ---
> drivers/staging/media/ipu3/ipu3.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/ipu3/ipu3.c b/drivers/staging/media/ipu3/ipu3.c
> index 84c4d0bf027d..14e30cf913b8 100644
> --- a/drivers/staging/media/ipu3/ipu3.c
> +++ b/drivers/staging/media/ipu3/ipu3.c
> @@ -556,8 +556,7 @@ static irqreturn_t imgu_isr_threaded(int irq, void *imgu_ptr)
> buf->vid_buf.vbb.vb2_buf.timestamp = ns;
> buf->vid_buf.vbb.field = V4L2_FIELD_NONE;
> buf->vid_buf.vbb.sequence =
> - atomic_inc_return(
> - &imgu_pipe->nodes[node].sequence);
> + atomic_inc_return(&imgu_pipe->nodes[node].sequence);
> dev_dbg(&imgu->pci_dev->dev, "vb2 buffer sequence %d",
> buf->vid_buf.vbb.sequence);
> }

--
Regards,

Sakari Ailus