Re: [PATCH v3] i2c: qcom-geni: Use devm_pm_runtime_enable() for PM management
From: Andi Shyti
Date: Tue Jul 28 2026 - 04:53:34 EST
Hi Mukesh,
On Tue, Jul 14, 2026 at 10:45:12AM +0530, Mukesh Kumar Savaliya wrote:
> The current implementation manually calls pm_runtime_enable() in probe()
> and pm_runtime_disable() in remove() and error paths. This pattern is
> error-prone and requires careful cleanup in all failure paths. Using the
> devres-managed variant eliminates this complexity.
>
> Migrate from manual pm_runtime_enable()/pm_runtime_disable() calls to
> the devres-managed devm_pm_runtime_enable() API. This simplifies the
> driver by automatically handling runtime PM cleanup when the device is
> removed or probe fails. This helps with Simplified error handling and
> Automatic cleanup.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> Signed-off-by: Mukesh Kumar Savaliya <mukesh.savaliya@xxxxxxxxxxxxxxxx>
merged to i2c/i2c.
Thanks,
Andi