Re: [PATCH v4 05/15] media: redrat3: Error path leaves device in transmitting state

[Markus Elfring]

>>> If the allocation fails, transmitting is left as true and the transmitter
>>> cannot be used any more.
>>
>> See also once more:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2-rc5#n94
> 
> I've tried to re-write the message in imperative mood, but doesn't look
> any better. It can be improved though, how about:
> 
> In the allocation failure error path, the transmitting boolean is not
> cleared and the transmitter cannot be used until the device is unplugged
> or the module reloaded.
> 
> Is that better?

Not really according to known wording requirements.

* Which allocation would have failed here?

* How do you think about to add a wording like the following to the introduction paragraph?

  Thus move an assignment statement.


> (I don't think we need a v5 just for a change of the commit message before
> commit.)
> 
>> …
>>> ---
>>>  drivers/media/rc/redrat3.c | 6 +++---…
>>
>> Some contributors would appreciate patch version descriptions.
>> https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2-rc5#n310
> 
> This patch has not changed since earlier versions.
Can the running patch review trigger further extensions for the changelog (in the cover letter)?
https://lore.kernel.org/linux-media/cover.1785158244.git.sean@xxxxxxxx/

Regards,
Markus