Re: [PATCH] dt-bindings: remoteproc: qcom,shikra-pas: Allow bam-dmux subnode

[Mukesh Ojha]

On Mon, Jul 27, 2026 at 08:11:05PM +0530, Mukesh Ojha wrote:
> On Mon, Jul 27, 2026 at 07:47:33PM +0530, Vishnu Santhosh wrote:
> > The BAM-DMUX node lives as a direct child of the modem PAS remoteproc
> > node, but qcom,shikra-pas.yaml has unevaluatedProperties: false and
> > does not list bam-dmux, so any DT adding this subnode fails schema
> > validation.
> > 
> > Add an optional bam-dmux property referencing qcom,bam-dmux.yaml,
> > mirroring qcom,msm8916-mss-pil.yaml.
> > 
> > Co-developed-by: Deepak Kumar Singh <deepak.singh@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Deepak Kumar Singh <deepak.singh@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Vishnu Santhosh <vishnu.santhosh@xxxxxxxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> > index 253b14eb2b598f0ca91854c8ff4d0b785090e621..17461d92165b26eb669809ed7dcdf029530c9223 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> > @@ -44,6 +44,11 @@ properties:
> >        - description: Firmware name of the Hexagon core
> >        - description: Firmware name of the Hexagon Devicetree
> >  
> > +  bam-dmux:
> > +    $ref: /schemas/net/qcom,bam-dmux.yaml#
> > +    description:
> > +      Qualcomm BAM Data Multiplexer (provides network interface to the modem)
> > +

Sasiko has valid comment on this, please address.


> >    glink-edge:
> >      $ref: /schemas/remoteproc/qcom,glink-edge.yaml#
> >      description:
> >
> 
> Reviewed-by: Mukesh Ojha <mukesh.ojha@xxxxxxxxxxxxxxxx>
> 
> -- 
> -Mukesh Ojha

-- 
-Mukesh Ojha