Re: [PATCH v4 3/3] remoteproc: qcom: pas: Add Nord ADSP and CDSP support

From: Shawn Guo

Date: Tue Jul 28 2026 - 06:04:10 EST


On Tue, Jul 28, 2026 at 11:19:56AM +0200, Konrad Dybcio wrote:
> On 7/28/26 10:40 AM, Shawn Guo wrote:
> > Add support for ADSP (HPASS DSP) and 4 CDSPs found on Nord SoC. The ADSP
> > is pre-booted by XBL before Linux starts, so set early_boot flag for
> > attach path rather than a cold boot sequence.
> >
> > Signed-off-by: Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx>
> > ---
>
> > +static const struct qcom_pas_data nord_adsp_resource = {
> > + .crash_reason_smem = 423,
> > + .firmware_name = "adsp.mdt",
>
> Please use .mbn everywhere

Ah, something copied over. Will update.

>
> with that:
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Thank you, Konrad!

Shawn