Re: [PATCH v9 1/7] drm/tyr: add resources to RegistrationData

[Danilo Krummrich]

On Thu Jul 23, 2026 at 1:54 AM CEST, Deborah Brouwer wrote:
> @@ -53,13 +51,17 @@
>  
>  #[pin_data(PinnedDrop)]
>  pub(crate) struct TyrPlatformDriverData<'bound> {
> -    _device: ARef<TyrDrmDevice>,
>      _reg: drm::Registration<'bound, TyrDrmDriver>,
>  }
>  
> +/// Data owned by the DRM [`Registration`].
> +///
> +/// This data can have references tied to the parent platform device binding scope
> +/// and is accessible only while the DRM device is registered with userspace.
>  #[pin_data]
> -pub(crate) struct TyrDrmDeviceData {
> -    pub(crate) pdev: ARef<platform::Device>,
> +pub(crate) struct TyrDrmRegistrationData<'bound> {

Please use a different lifetime name for this, 'bound should only be used for
the bus device private data itself, as its lifetime defines this scope. Maybe
use 'drm instead?

The same is true for a couple of other places in this series, such as
Mmu<'bound>, VmAsData<'bound>, etc.

Please feel free to fix up on apply or in a follow-up patch.