Re: [PATCH wireless-next] wifi: nxpwifi: embed rx_reorder_ptr

[Jeff Chen]

On Sun, Jul 26, 2026 at 05:29:16 PM -0700, Rosen Penev wrote:
> rx_reorder_ptr is a dynamically allocated array which is done near the
> main struct allocation. Combine the two to avoid freeing separately.
> 
> Also fix the type to what it actually is. void is normally used to avoid
> casting but there's no need here.
> 
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> ---
>  .../net/wireless/nxp/nxpwifi/11n_rxreorder.c  | 19 +++----------------
>  drivers/net/wireless/nxp/nxpwifi/main.h       |  2 +-
>  2 files changed, 4 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/net/wireless/nxp/nxpwifi/11n_rxreorder.c b/drivers/net/wireless/nxp/nxpwifi/11n_rxreorder.c
> index c5819f89b08c..b2fd624497a3 100644
> --- a/drivers/net/wireless/nxp/nxpwifi/11n_rxreorder.c
> +++ b/drivers/net/wireless/nxp/nxpwifi/11n_rxreorder.c
> @@ -171,7 +171,6 @@ nxpwifi_del_rx_reorder_entry(struct nxpwifi_private *priv,
>  	list_del_rcu(&tbl->list);
>  	spin_unlock_bh(&priv->rx_reorder_tbl_lock[tid]);
>  

Hi Rosen,

Thanks for the patch.

This patch triggers an unused variable warning since the for-loop was removed:

../drivers/net/wireless/nxp/nxpwifi/11n_rxreorder.c:264:6: warning: unused variable 'i' [-Wunused-variable]
  264 |         int i;
      |             ^