Re: [PATCH 2/2] nvme: drop WARN_ON_ONCE on write_stream bounds check
From: Greg Kroah-Hartman
Date: Tue Jul 28 2026 - 06:48:31 EST
On Tue, Jul 28, 2026 at 03:46:50AM -0600, Keith Busch wrote:
> On Tue, Jul 28, 2026 at 08:58:00AM +0200, Greg Kroah-Hartman wrote:
> > I'm tired of it too, but again, if this can be hit by something a user
> > does, it ends up being a DoS on the machine :(
>
> Why do you think has something to do with what a user does? The
> filesystem and block layers own the write stream, and the contract is it
> has to be within the reported limits. If it's not, there's a filesystem
> bug; nothing to do with the user.
I don't think this specific issue is something that a user can trigger,
as I really don't know how this code path works. I was making the
larger statement of "If a user can hit a WARN_ON() kernel call, then it
should be fixed to properly handle that logic."
thanks,
greg k-h