Re: [PATCH V4 2/4] dt-bindings: mmc: sdhci-msm: Document the Glymur compatible
From: Krzysztof Kozlowski
Date: Tue Jul 28 2026 - 08:23:00 EST
On 28/07/2026 14:02, Monish Chunara wrote:
>
>
> On 7/24/2026 1:24 AM, Rob Herring wrote:
>> On Wed, Jul 22, 2026 at 07:53:40PM +0530, Monish Chunara wrote:
>>> From: Monish Chunara <monish.chunara@xxxxxxxxxxxxxxxx>
>>>
>>> Document the SDHCI controller on Qualcomm Glymur SoC, fully compatible
>>> with existing MSM SDHCI v5.
>>>
>>> Signed-off-by: Monish Chunara <monish.chunara@xxxxxxxxxxxxxxxx>
>>
>> Missing krzk's ack.
>>
>> Rob
>
> I wasn't sure whether to carry over the Acked-by tag since the commit
> message changed, so I left it out and queried on the previous series.
>
> I'll make sure to retain it appropriately in future patches.
And where is it explained? Please quote me the cover letter explaining this.
You did not read neither kernel docs nor internal guideline.
And please explain me the logic behind your thinking - you received
comment from the reviewer and tag, you implemented the comment of
reviewer and this means that reviewer did not ack it?
How does this logic exactly work?
Best regards,
Krzysztof