Re: [PATCH 04/13] arm64: dts: exynos8855: add cmu_top & cmu_peric clock DT nodes

[Krzysztof Kozlowski]

On 28/07/2026 14:23, Alim Akhtar wrote:
> Hi Krzysztof,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>> Sent: Tuesday, July 28, 2026 5:30 PM
>> To: raghav.s <raghav.s@xxxxxxxxxxx>; s.nawrocki@xxxxxxxxxxx;
>> cw00.choi@xxxxxxxxxxx; peter.griffin@xxxxxxxxxx;
>> alim.akhtar@xxxxxxxxxxx; mturquette@xxxxxxxxxxxx; sboyd@xxxxxxxxxx;
>> bmasney@xxxxxxxxxx; robh@xxxxxxxxxx; conor+dt@xxxxxxxxxx
>> Cc: linux-samsung-soc@xxxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx;
>> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
>> kernel@xxxxxxxxxxxxxxx; hajun.sung@xxxxxxxxxxx;
>> is.gandhi@xxxxxxxxxxx; ts.amit@xxxxxxxxxxx;
>> pokala.reddy@xxxxxxxxxxx
>> Subject: Re: [PATCH 04/13] arm64: dts: exynos8855: add cmu_top &
>> cmu_peric clock DT nodes
>>
>> On 28/07/2026 14:11, raghav.s wrote:
>>> Add required dt node for cmu_top & cmu_peric block
>>>
>>> Signed-off-by: raghav.s <raghav.s@xxxxxxxxxxx>
>>> ---
>>>  arch/arm64/boot/dts/exynos/exynos8855.dtsi | 24
>>> ++++++++++++++++++++++
>>>  1 file changed, 24 insertions(+)
>>
>> Please organize your patches in reasonable order. DTS is never in the middle,
>> see submitting patches (both documents) and maintainer-soc profile.
>>
> The thought was to add clks block wise and hence we see DTS coming in between but for the other blocks. 
> e.g. patch-2 and 3 adds binding and driver for TOP and PERIC and this patch-4 adds DTS. 
> And patch-5 and 6 adds binding and driver for PERIS and patch-7 adds DTS and so on.
> 
> Cover-letter should have explained this. 
> 
> Are you suggesting to re-order all the binding first followed by all blocks driver and then add a single DTS for all clock controller? 
> 
> Does current approach helps in review? 

If you ask this, you did not read the docs.

Best regards,
Krzysztof