Re: (subset) [PATCH v10 0/7] clk: qcom: Add common clkref support and migrate Glymur and Mahua

[Rob Herring]

On Sun, Jul 26, 2026 at 10:22 PM Bjorn Andersson <andersson@xxxxxxxxxx> wrote:
>
>
> On Tue, 21 Jul 2026 22:58:55 -0700, Qiang Yu wrote:
> > This series adds a common clkref_en implementation and converts glymur
> > and mahua to use it, along with the related binding and DTS updates.
> >
> > The PCIe clkref clocks on Glymur and Mahua gate the QREF block which
> > provides reference clocks to the PCIe PHYs. QREF requires LDO supplies
> > and a reference voltage from the refgen block to operate. The refgen
> > block itself requires vdda-refgen_0p9 and vdda-refgen_1p2 LDOs to
> > function.
> >
> > [...]
>
> Applied, thanks!
>
> [1/7] dt-bindings: clock: qcom: Move glymur TCSR to own binding
>       commit: f9cbc4bddb636dd9d446bfba31f58fbceaf09424
> [2/7] dt-bindings: clock: qcom,glymur-tcsr: Add mahua support
>       commit: 0998cf30b0e0d02dbcdfc1f989b745137b21f682
> [3/7] clk: qcom: Add generic clkref_en support
>       commit: 22c70e5732005356a4bc2601e7dcf878aab101e0
> [4/7] clk: qcom: tcsrcc-glymur: Add regulator supplies and migrate to clk_ref helper
>       commit: 0753091abc4b480abf76cb40c10fffe2764bfcf7
> [5/7] clk: qcom: tcsrcc-glymur: Add Mahua QREF regulator support
>       commit: 0f87ded5f8398182fbac232f0f287d45baa10d6a

A bunch of new warnings with this series:

      2 (qcom,glymur-tcsr): 'vdda-refgen4-1p2-supply' is a required property
      2 (qcom,glymur-tcsr): 'vdda-refgen4-0p9-supply' is a required property
      2 (qcom,glymur-tcsr): 'vdda-refgen3-1p2-supply' is a required property
      2 (qcom,glymur-tcsr): 'vdda-refgen3-0p9-supply' is a required property
      2 (qcom,glymur-tcsr): 'vdda-qreftx1-0p9-supply' is a required property
      2 (qcom,glymur-tcsr): 'vdda-qreftx0-1p2-supply' is a required property
      2 (qcom,glymur-tcsr): 'vdda-qreftx0-0p9-supply' is a required property
      2 (qcom,glymur-tcsr): 'vdda-qrefrx5-0p9-supply' is a required property
      2 (qcom,glymur-tcsr): 'vdda-qrefrx4-0p9-supply' is a required property
      2 (qcom,glymur-tcsr): 'vdda-qrefrx2-0p9-supply' is a required property
      2 (qcom,glymur-tcsr): 'vdda-qrefrx1-0p9-supply' is a required property
      2 (qcom,glymur-tcsr): 'vdda-qrefrx0-0p9-supply' is a required property
      2 (qcom,glymur-tcsr): 'vdda-qrefrpt4-0p9-supply' is a required property
      2 (qcom,glymur-tcsr): 'vdda-qrefrpt3-0p9-supply' is a required property
      2 (qcom,glymur-tcsr): 'vdda-qrefrpt2-0p9-supply' is a required property
      2 (qcom,glymur-tcsr): 'vdda-qrefrpt1-0p9-supply' is a required property
      2 (qcom,glymur-tcsr): 'vdda-qrefrpt0-0p9-supply' is a required property

Rob