Re: [PATCH] staging: rtl8723bs: fix line length warnings in os_intfs.c

[Greg KH]

On Tue, Jul 28, 2026 at 06:26:43PM +0300, Bramwel Barack wrote:
> The current formatting standards in the file rtl8723bs violates the
> kernel coding standards of 100 lines.
> Targeted most comments of code while avoiding key functions and comments
> included due to indents.
> 
> >From 08a6ba8dd59504c030c0e6c9f9459a53436d32eb Mon Sep 17 00:00:00 2001
> From: Bramwel Barack <bramwelbarack89@xxxxxxxxx>
> Date: Tue, 28 Jul 2026 17:50:30 +0300
> Subject: [PATCH] staging: rtl8723bs: fix line length warnings in os_intfs.c
> 
> Signed-off-by: Bramwel Barack <bramwelbarack89@xxxxxxxxx>

No changelog text?  Something went wrong here, perhaps use `b4` to
create and send patches out?  Heck, even I've started using it, it
really is a nice workflow to learn.

> ---
>  drivers/staging/rtl8723bs/os_dep/os_intfs.c | 37 ++++++++++++++++-----
>  1 file changed, 29 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index c15056ee207c..c916f6f52253 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -71,20 +71,36 @@ int rtw_ht_enable = 1;
>   * 0x01 means enable 2.4G 40MHz
>   */
>  static int rtw_bw_mode = 0x01;
> -static int rtw_ampdu_enable = 1;/* for enable tx_ampdu ,0: disable, 0x1:enable (but wifi_spec should be 0), 0x2: force enable (don't care wifi_spec) */
> +static int rtw_ampdu_enable = 1;
> +/*  for enable tx_ampdu ,0: disable */
> +/*  0x1:enable (but wifi_spec should be 0) */
> +/*  0x2: force enable (don't care wifi_spec) */

Shouldn't the comment be on the top of the variable?

thanks,

greg k-h