RE: [Intel-wired-lan] [PATCH net v2] idpf: Fix mailbox IRQ name leak on request failure

[Salin, Samuel]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of
> Loktionov, Aleksandr
> Sent: Tuesday, July 7, 2026 6:32 AM
> To: Yuho Choi <dbgh9129@xxxxxxxxx>; Nguyen, Anthony L
> <anthony.l.nguyen@xxxxxxxxx>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@xxxxxxxxx>; Andrew Lunn <andrew+netdev@xxxxxxx>;
> David S . Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet
> <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni
> <pabeni@xxxxxxxxxx>
> Cc: intel-wired-lan@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [Intel-wired-lan] [PATCH net v2] idpf: Fix mailbox IRQ name leak
> on request failure
> 
> 
> 
> > -----Original Message-----
> > From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf
> > Of Yuho Choi
> > Sent: Friday, July 3, 2026 7:04 AM
> > To: Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; Kitszel,
> > Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>; Andrew Lunn
> > <andrew+netdev@xxxxxxx>; David S . Miller <davem@xxxxxxxxxxxxx>; Eric
> > Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>;
> Paolo
> > Abeni <pabeni@xxxxxxxxxx>
> > Cc: intel-wired-lan@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx; Yuho Choi <dbgh9129@xxxxxxxxx>
> > Subject: [Intel-wired-lan] [PATCH net v2] idpf: Fix mailbox IRQ name
> > leak on request failure
> >
> > idpf_mb_intr_req_irq() allocates the mailbox IRQ name before calling
> > request_irq(). On success, the name is released later through
> > kfree(free_irq()), but request_irq() failure returns without freeing
> > it.
> >
> > Free the allocated name on the request_irq() failure path.
> >
> > Fixes: 4930fbf419a7 ("idpf: add core init and interrupt request")
> > Signed-off-by: Yuho Choi <dbgh9129@xxxxxxxxx>
> > ---
> > Changes in v2:
> > - Add net tag for the patch subject line.
> >  drivers/net/ethernet/intel/idpf/idpf_lib.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c
> > b/drivers/net/ethernet/intel/idpf/idpf_lib.c
> > index cf966fe6c759..bb81e620c5c8 100644
> > --- a/drivers/net/ethernet/intel/idpf/idpf_lib.c
> > +++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c
> > @@ -139,7 +139,7 @@ static int idpf_mb_intr_req_irq(struct
> > idpf_adapter *adapter)
> >  	if (err) {
> >  		dev_err(&adapter->pdev->dev,
> >  			"IRQ request for mailbox failed, error: %d\n", err);
> > -
> > +		kfree(name);
> >  		return err;
> >  	}
> >
> > --
> > 2.43.0
> 
> 
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>

Tested-by: Samuel Salin <Samuel.salin@xxxxxxxxx>