Re: [PATCH] media: staging/ipu7: fix async notifier leak on init error

[Sakari Ailus]

Hi Cong,

Thanks for the patch.

On Mon, Jul 27, 2026 at 06:22:39PM +0700, Cong Nguyen wrote:
> isys_notifier_init() initialises a v4l2 async notifier and then, for
> each CSI-2 port, adds a remote sensor subdev to the notifier's
> waiting_list via v4l2_async_nf_add_fwnode_remote(), which allocates a
> sensor_async_sd descriptor and takes a fwnode reference.
> 
> If parsing or adding a later port fails, the code jumps to the
> "err_parse" label, which only drops the current endpoint fwnode
> reference and returns, without calling v4l2_async_nf_cleanup(). Any
> descriptors already added to the notifier for earlier ports are
> therefore leaked, and the caller's error path does not clean up the
> notifier either.
> 
> Call v4l2_async_nf_cleanup() on the error path, matching the cleanup
> already performed when v4l2_async_nf_register() fails. This is safe as
> the notifier is always initialised before the loop is entered.
> 
> Fixes: a516d36bdc3d ("media: staging/ipu7: add IPU7 input system device driver")
> Signed-off-by: Cong Nguyen <congnt264@xxxxxxxxx>

The patch is fine, but there's another issue there, see
<URL:https://linuxtv.org/mailman3/hyperkitty/list/media-ci@xxxxxxxxxxx/message/G5DTPKTRTWM5PBTFQJP2HI7T324FZF5D/>.

Feel free to post a patch for that, too.

-- 
Kind regards,

Sakari Ailus