Re: [PATCH 00/14] perf c2c: add a function view
From: Namhyung Kim
Date: Tue Jul 28 2026 - 14:30:30 EST
On Fri, Jul 24, 2026 at 06:10:29PM +0800, Jiebin Sun wrote:
> Hi Namhyung,
>
> Thanks a lot for the review and for confirming the layout.
>
> I've just posted v4 with the reworked hierarchy:
>
> Level 1: the read-side function (pays the estimated HITM/peer
> load-cycle cost)
> Level 2: the contending function that writes the shared lines
> Level 3: the specific shared cachelines
>
> Every level now shows functions and cachelines only, with per-level
> indentation; the code addresses and offsets are no longer shown in the
> main view -- they remain available in the cacheline detail view. The
> series is also reorganized into 9 logically self-contained patches.
Great, much better now!
>
> > ... add a shortcut to the cacheline view on the given item.
>
> The function view already supports this for level-3 cacheline entries:
> pressing 'd' opens the corresponding cacheline detail view.
Ok, nice!
Thanks,
Namhyung