Re: [PATCH v3 2/3] hwmon: (emc1403) Convert to use OF bindings
From: Guenter Roeck
Date: Tue Jul 28 2026 - 18:16:38 EST
On 7/28/26 14:44, Uwe Kleine-König wrote:
On Sat, Jul 25, 2026 at 07:23:13AM -0700, Guenter Roeck wrote:FWIW, my feedback wasn't directed at you.
On 7/25/26 06:24, Svyatoslav Ryhel wrote:
чт, 23 лип. 2026 р. о 09:28 Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxx> пише:
Hello,
On Tue, Jul 21, 2026 at 12:59:34PM +0300, Svyatoslav Ryhel wrote:
From: Jonas Schwöbel <jonasschwoebel@xxxxxxxx>
Add OF match compatible table to be able to use this driver with Device
Trees.
Signed-off-by: Jonas Schwöbel <jonasschwoebel@xxxxxxxx>
Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Please put your S-o-b line last.
If S-o-b's should be chronological, then this order is correct.
Guenter added his reviewed-by after I have added my signed-off-by.
It's a nitpick, but as you added Guenter's tag, you modified the commit
log and then your S-o-b has to be renewed.
That refers to S-o-B, not to Reviewed-by: trailers.
Do we really have to argue about something like this ? Do I have
to mandate the order of non-SoB trailers for this subsystem ?
I wouldn't have replied just for the order, but I think it's convenient
and usual to have the own S-o-b last.
Depends on you how strict you want to be here, as usual. I for my part
ask for reordering or announce to fix the ordering if nothing else is in
the way for application.
Guenter