Re: [PATCH wireless-next] wifi: cfg80211: add fw_version device attribute for sysfs

[Rory Little]

On 7/28/26 18:34, Jeff Johnson wrote:
> On 7/28/2026 4:47 PM, Rory Little wrote:
> > The firmware version is already exposed via ethtool, but is not
> > accessible without an attached interface to create a netdev. Expose this
> > info in sysfs to allow users to query it without the use of ethtool.
> Curious what is the value?

Here are some that I have seen:

10.4-ct-9984-xtH-011-33ec52c8
____000000-20251118163234
____000000-20251015213023
DEV_000000-20240823172837
DEV_000000-20220929104205
89.7207fc64.0 ty-a0-gf-a0-89.uc

Top one is ath10k with CT firmware, next four are an assortment of 
Mediatek radios, bottom is Intel.

> It looks like many drivers, including ath11k and ath12k, do not populate this.
>
> And this attribute is pointless for Wi-Fi 7 drivers supporting MLO with
> multiple underlying hardware running different firmware images. I suspect
> there are a few wiphy attributes that have this issue.
>
> You'd need to instantiate these attribute on a per-radio basis to properly
> handle the new multi-radio wiphy model.

Hm, good point. It seems like it would either need a fw_version member 
on the wiphy_radio struct, or something similar to the addresses field 
off the wiphy. Would either of those be acceptable solutions?

- Rory

> /jeff