Re: [PATCH v4 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

[Jacky Huang]

Hi Rob,

Thank you very much for the review.

On Tue, Jul 28, 2026 at 09:39:52AM -0500, Rob Herring wrote:
> > +				cp2112g: device@2 {
>
> This and other devices should have a compatible string and associated
> schema. The hub probably should too.

Will fix in v5.

> > +	flash@0 {
>
> Needs a compatible.

The flash@0 node augments the corresponding node defined in
aspeed-g6.dtsi, which already carries compatible = "jedec,spi-nor",
so the compatible is inherited. The same applies to the flash@0
under &spi2.

> > +		status = "okay";
>
> okay is the default, so not needed.

The flash@0 node in aspeed-g6.dtsi is status = "disabled", so the
board file needs status = "okay" to enable it.

Jacky