Re: [PATCH v2] regulator: dt-bindigs: ti,pbias-omap: Convert to DT schema

[Bhargav Joshi]

On Tue, Jul 28, 2026 at 3:57 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On Wed, Jul 22, 2026 at 09:55:07PM +0530, Bhargav Joshi wrote:
> > Convert Texas Instruments PBIAS internal regulator from text to DT
> > schema. No Functional changes are introduced.
>
> Subject - typo, dt-bindings.
>
> >
> > Signed-off-by: Bhargav Joshi <j.bhargav.u@xxxxxxxxx>
> > ---
> > Changes in v2:
> > - remove top level $ref: regulator.yaml#
> > - update schema to support OMAP3 SoCs to have both MMC and
> >   SIM PBIAS regulators
> > - Link to v1: https://lore.kernel.org/r/20260717-ti-pbias-omap-v1-1-527848131801@xxxxxxxxx
> > ---
> >  .../bindings/regulator/pbias-regulator.txt         |  32 -----
> >  .../bindings/regulator/ti,pbias-omap.yaml          | 157 +++++++++++++++++++++
> >  2 files changed, 157 insertions(+), 32 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/regulator/pbias-regulator.txt b/Documentation/devicetree/bindings/regulator/pbias-regulator.txt
> > deleted file mode 100644
> > index acbcb452a69a..000000000000
> > --- a/Documentation/devicetree/bindings/regulator/pbias-regulator.txt
> > +++ /dev/null
> > @@ -1,32 +0,0 @@
> > -PBIAS internal regulator for SD card dual voltage i/o pads on OMAP SoCs.
> > -
> > -Required properties:
> > -- compatible:
> > -  - should be "ti,pbias-dra7" for DRA7
> > -  - should be "ti,pbias-omap2" for OMAP2
> > -  - should be "ti,pbias-omap3" for OMAP3
> > -  - should be "ti,pbias-omap4" for OMAP4
> > -  - should be "ti,pbias-omap5" for OMAP5
> > -  - "ti,pbias-omap" is deprecated
> > -- reg: pbias register offset from syscon base and size of pbias register.
> > -- syscon : phandle of the system control module
> > -- regulator-name : should be
> > -                     pbias_mmc_omap2430 for OMAP2430, OMAP3 SoCs
> > -                     pbias_sim_omap3 for OMAP3 SoCs
> > -                     pbias_mmc_omap4 for OMAP4 SoCs
> > -                     pbias_mmc_omap5 for OMAP5 and DRA7 SoC
> > -
> > -Optional properties:
> > -- Any optional property defined in bindings/regulator/regulator.txt
> > -
> > -Example:
> > -
> > -             pbias_regulator: pbias_regulator {
> > -                     compatible = "ti,pbias-omap";
> > -                     reg = <0 0x4>;
> > -                     syscon = <&omap5_padconf_global>;
> > -                     pbias_mmc_reg: pbias_mmc_omap5 {
> > -                             regulator-name = "pbias_mmc_omap5";
> > -                             regulator-min-microvolt = <1800000>;
> > -                             regulator-max-microvolt = <3000000>;
> > -                     };
> > diff --git a/Documentation/devicetree/bindings/regulator/ti,pbias-omap.yaml b/Documentation/devicetree/bindings/regulator/ti,pbias-omap.yaml
> > new file mode 100644
> > index 000000000000..ea904946e352
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/regulator/ti,pbias-omap.yaml
> > @@ -0,0 +1,157 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/regulator/ti,pbias-omap.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Texas Instruments PBIAS internal regulator.
>
> Drop final stop. Titles don't have them.
>
> > +
> > +maintainers:
> > +  - Tony Lindgren <tony@xxxxxxxxxxx>
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - ti,pbias-dra7
> > +          - ti,pbias-omap2
> > +          - ti,pbias-omap3
> > +          - ti,pbias-omap4
> > +          - ti,pbias-omap5
> > +      - const: ti,pbias-omap
>
> Odd, old binding did not list such order and it said ti,pbias-omap is
> deprecated.

no in-tree DT has used bare "ti,pbias-omap" since series that added the
per-SoC compatibles every dtsi already uses the two-string form. So I
kept it this way. I Will add that to the commit message for v3.
>
> Nothing in commit msg explains changes done to the binding. I guess
> there is a reason to do that, but needs to be explicit. Especially that
> you are changing the ABI - disallowing ti,pbias-omap alone.
>
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  syscon:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +    description: phandle of the system control module
> > +
> > +  pbias_mmc_omap2430:
>
> Names were also not in the old binding and this is not explained WHY you
> are doing that way.

These exact node names are matched by the driver so need to be added in
binding, I will document this in the commit message.

>
> > +    type: object
> > +    $ref: regulator.yaml#
> > +
> > +    properties:
> > +      regulator-name:
> > +        const: pbias_mmc_omap2430
>
> So the regulator-name is required or node name? Looking at the code I
> see only node name requirement, but feel free to elaborate in commit msg
> why this name must be fixed as well.
>
Yes, only node names are matched , there is no restriction on
regulator name even
though current in tree DT uses these exact regulator-name, I'll fix this in v3
> > +
> > +    required:
> > +      - regulator-name
> > +
> > +    unevaluatedProperties: false
>
> Place this one after $ref.
>
sure
> > +
> > +  pbias_sim_omap3:
> > +    type: object
> > +    $ref: regulator.yaml#
> > +
> > +    properties:
> > +      regulator-name:
> > +        const: pbias_sim_omap3
> > +
> > +    required:
> > +      - regulator-name
> > +
> > +    unevaluatedProperties: false
>
> Ditto
>
> > +
> > +  pbias_mmc_omap4:
> > +    type: object
> > +    $ref: regulator.yaml#
> > +
> > +    properties:
> > +      regulator-name:
> > +        const: pbias_mmc_omap4
> > +
> > +    required:
> > +      - regulator-name
> > +
> > +    unevaluatedProperties: false
>
> Ditto
>
> > +
> > +  pbias_mmc_omap5:
> > +    type: object
> > +    $ref: regulator.yaml#
> > +
> > +    properties:
> > +      regulator-name:
> > +        const: pbias_mmc_omap5
> > +
> > +    required:
> > +      - regulator-name
> > +
> > +    unevaluatedProperties: false
>
> Ditto
>
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - syscon
> > +
> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: ti,pbias-omap2
> > +    then:
> > +      required:
> > +        - pbias_mmc_omap2430
> > +      properties:
> > +        pbias_sim_omap3: false
> > +        pbias_mmc_omap4: false
> > +        pbias_mmc_omap5: false
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: ti,pbias-omap3
> > +    then:
> > +      anyOf:
> > +        - required:
> > +            - pbias_mmc_omap2430
> > +        - required:
> > +            - pbias_sim_omap3
> > +      properties:
> > +        pbias_mmc_omap4: false
> > +        pbias_mmc_omap5: false
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: ti,pbias-omap4
> > +    then:
> > +      required:
> > +        - pbias_mmc_omap4
> > +      properties:
> > +        pbias_mmc_omap2430: false
> > +        pbias_sim_omap3: false
> > +        pbias_mmc_omap5: false
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - ti,pbias-omap5
> > +              - ti,pbias-dra7
> > +    then:
> > +      required:
> > +        - pbias_mmc_omap5
> > +      properties:
> > +        pbias_mmc_omap2430: false
> > +        pbias_sim_omap3: false
> > +        pbias_mmc_omap4: false
> > +
> > +unevaluatedProperties: false
>
> additionalProperties instead.
yes will fix this as well.
>
> > +
> > +examples:
> > +  - |
> > +    pbias_regulator: pbias_regulator@0 {
>
> Drop unused label.
>
sure

Best regards,
Bhargav