Re: [PATCH v8 1/2] dt-bindings: bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver

[Mohit Dsor]

On Wed, Jul 29, 2026 at 08:37:42AM +0200, Krzysztof Kozlowski wrote:
> On Wed, Jul 29, 2026 at 08:18:58AM +0200, Krzysztof Kozlowski wrote:
> > On 28/07/2026 13:09, mohit.dsor@xxxxxxxxxxxxxxxx wrote:
> > > From: Sunyun Yang <syyang@xxxxxxxxxxx>
> > > 
> > > LT9611C(EX/UXD) is an I2C-controlled chip that Receiver signal/dual port
> > > mipi dsi and output hdmi, differences in hardware features:
> > > - LT9611C: supports 1-port mipi dsi to hdmi 1.4
> > > - LT9611EX: supports 2-port mipi dsi to hdmi 1.4
> > > - LT9611UXD: supports 2-port mipi dsi to hdmi 1.4/2.0
> > > 
> > > Signed-off-by: Sunyun Yang <syyang@xxxxxxxxxxx>
> > > Signed-off-by: Mohit Dsor <mdsor@xxxxxxxxxxxxxxxx>
> > > ---
> > 
> > NAK. You received review. Sending the same is wasting our time.
> 
> Actually you ignored TWO independent reviews, so I will not waste time
> on this patchset anymore.
1.
>> So you need "if:then:" block disallowing port@1.
>Ok, need to add in driver code? Will add this in v8.
 
Sorry, I missed adding this in the bindings. I assumed a driver-side check would be sufficient, so I added the following validation in the driver:
+       if (lt9611c->dsi1_node && lt9611c->chip_type == CHIP_LT9611C) {
+               of_node_put(lt9611c->dsi1_node);
+               of_node_put(lt9611c->dsi0_node);
+               return dev_err_probe(dev, -EINVAL,
+                                    "LT9611C does not support dual DSI\n");
+       }
 
 
If I understand your suggestion correctly, it would be preferable to enforce this constraint in the DT bindings as well.
let me know if this is correct approach for DT bindings:
 
--- a/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/lontium,lt9611.yaml
@@ -82,6 +82,16 @@ required:
allOf:
   - $ref: /schemas/sound/dai-common.yaml#
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: lontium,lt9611c
+    then:
+      properties:
+        ports:
+          properties:
+            port@1: false

2. These are some odd characters here. I guess this was in earlier versions
as well....
I am sorry for this, I missed it. I will correct it in v9.
> 
> Best regards,
> Krzysztof
>