Re: [PATCH 2/2] selftests/cgroup: write explicit period to cpu.max in max tests

[Michal Koutný]

Hi.

Here I cannot appreciate the changes.

On Wed, Jul 29, 2026 at 06:04:51PM +0800, Shaojie Sun <sunshaojie@xxxxxxxxxx> wrote:
> The cpu.max interface accepts "quota period" as two values, but
> test_cpucg_max and test_cpucg_max_nested only wrote the quota,
> relying on the kernel default period of 100ms.

Yes. Is that a problem?

> Write both values explicitly so that the period can be easily
> adjusted for testing purposes and the remainder logic becomes
> genuinely useful.

I have yet to see a system where the default period is modified.
Therefore, I wouldn't open that box with non-default periods
unnecessarily.

Thanks,
Michal

Attachment: signature.asc
Description: PGP signature