Re: [PATCH ipsec] xfrm: do not take x->lock under xfrm_state_lock in the NAT keepalive walk

[Eyal Birger]

Hi,

On Tue, Jul 28, 2026 at 8:29 PM Yuejie Shi <syjcnss@xxxxxxxxx> wrote:
>
> nat_keepalive_work() walks the SA list with xfrm_state_walk(), which
> holds net->xfrm.xfrm_state_lock across the callback, and
> nat_keepalive_work_single() then takes x->lock underneath it.

Thanks for the fix, but I believe it has already been addressed in a
different way at:

https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec.git/commit/?id=763fe700b7c58ad64fe5202c5638848244dd4127

Eyal.