Re: [PATCH] misc: hisi_hikey_usb: cancel role switch work on remove

From: Arnd Bergmann

Date: Wed Jul 29 2026 - 10:54:08 EST


On Wed, Jul 29, 2026, at 15:42, Greg Kroah-Hartman wrote:
> On Wed, Jul 29, 2026 at 06:56:18PM +0800, Hongyan Xu wrote:
>> Thanks for the context. I wasn't aware that the driver had no upstream
>> DT user or binding.
>>
>> Given that, I will hold off on revising this patch. If removing the
>> unused driver is the preferred direction, I can prepare a separate
>> removal patch.
>
> Sorry, yes, that's what I was wanting to ask as well.

I asked around internally, and Ben Copeland mentioned that the hikey960
itself should still work fine with mainline kernels, but the role switch
driver was never getting tested.

I think we can just remove this driver. If anyone wants to get
the functionality working later, they can reintroduce a working
version in drivers/phy/, where all other usb-role-switch support
lives these days.

Arnd