Re: [PATCH] crypto: ecc - Add NIST P224 curve parameters

[Lukas Wunner]

On Wed, Jul 29, 2026 at 05:51:04PM +0200, Paul Louvel wrote:
> Add the parameters for the NIST P224 curve and define a new curve ID for
> it. Make the curve available in ecc_get_curve().

Usually we'd also want test vectors in crypto/testmgr.h.

> +static struct ecc_curve nist_p224 = {
> +	.name = "nist_224",
> +	.nbits = 224,
> +	.g = {
> +		.x = nist_p224_g_x,
> +		.y = nist_p224_g_y,
> +		.ndigits = 4,

This should be 3 because DIV_ROUND_UP(224, 64) = 3.

Thanks,

Lukas