Re: [PATCH] x86/CPU/AMD: Fix Zen5 models id

[Yazen Ghannam]

On Wed, Jul 29, 2026 at 05:54:59AM +0000, Pratik Vishwakarma wrote:

Hi Pratik,

The $SUBJECT say "Fix", but this patch is adding/identifying new models.

> Family 0x1a model 0xd0..0xd7 are X86_FEATURE_ZEN5

The commit message should be worded in a different way. See these docs:
  Documentation/process/submitting-patches.rst
  Documentation/process/maintainer-tip.rst

> 
> Signed-off-by: Pratik Vishwakarma <Pratik.Vishwakarma@xxxxxxx>
> ---
>  arch/x86/kernel/cpu/amd.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
> index 487ac147e11f..d61df70d6875 100644
> --- a/arch/x86/kernel/cpu/amd.c
> +++ b/arch/x86/kernel/cpu/amd.c
> @@ -515,11 +515,13 @@ static void bsp_init_amd(struct cpuinfo_x86 *c)
>  		case 0x00 ... 0x2f:
>  		case 0x40 ... 0x4f:
>  		case 0x60 ... 0x7f:
> +		case 0xd0 ... 0xd7:
>  			setup_force_cpu_cap(X86_FEATURE_ZEN5);
>  			break;
>  		case 0x50 ... 0x5f:
>  		case 0x80 ... 0xaf:
> -		case 0xc0 ... 0xef:
> +		case 0xc0 ... 0xcf:
> +		case 0xd8 ... 0xef:

These changes are not what is described in the commit message.

>  			setup_force_cpu_cap(X86_FEATURE_ZEN6);
>  			break;
>  		default:
> -- 

It seems there is an "issue to fix".

A model group D0h-DFh was misidentified as Zen6 when it really is Zen5.

Please make this clear in the commit message.

Thanks,
Yazen