Re: [PATCH] IB/isert: post full-feature receive buffers after session registration

[Yehyeong Lee]

Thanks for the review.

On Wed, Jul 29, 2026 at 04:01:41PM +0300, Leon Romanovsky wrote:
> 1. Please keep commit messages concise and easy to read.
> 2. Include the full kernel Oops in the commit message.
> 3. Keep code comments to a minimum.

I will fix all three in v2.

> 4. Please address Sashiko's concerns about this patch.

Posting the receive buffers from the RX thread does leave the receive
queue empty between the final Login Response going out and
isert_get_rx_pdu() running. On IB and RoCE that is absorbed by the
rnr_retry_count = 7 that isert_rdma_accept() puts in the REP, but iWARP
has no RNR flow control and cma_accept_iw() ignores the field, so the
patch as posted is wrong there.

v2 will post the buffers in isert_put_login_tx() as before and delay the
final Login Response instead. An initiator cannot enter Full Feature
before it sees that response, so the queue is never empty and no command
can arrive before __transport_register_session().

Best regards,
Yehyeong