Re: [PATCH v3 3/5] zram: add level validation in zstd setup_params

[Sergey Senozhatsky]

On (26/07/30 10:52), Haoqin Huang wrote:
[..]
> diff --git a/drivers/block/zram/backend_zstd.c b/drivers/block/zram/backend_zstd.c
> index 2584f47c9b3c..6febb366f76e 100644
> --- a/drivers/block/zram/backend_zstd.c
> +++ b/drivers/block/zram/backend_zstd.c
> @@ -60,6 +60,11 @@ static int zstd_setup_params(struct zcomp_params *params)
>  	params->drv_data = zp;
>  	if (params->level == ZCOMP_PARAM_NOT_SET)
>  		params->level = zstd_default_clevel();
> +	else if (params->level < -(int)ZSTD_TARGETLENGTH_MAX ||

I was expecting to see zstd_min_clevel() here.  What is this
-(int)ZSTD_TARGETLENGTH_MAX?

> +		 params->level > zstd_max_clevel()) {
> +		pr_err("zstd: invalid compression level %d\n", params->level);
> +		goto error;
> +	}