Re: [PATCHv2] powerpc/44x: Set GPIO chip parent

From: Christophe Leroy (CS GROUP)

Date: Thu Jul 30 2026 - 01:53:30 EST




Le 17/07/2026 à 21:05, Rosen Penev a écrit :
On Sat, May 16, 2026 at 11:38 PM Rosen Penev <rosenp@xxxxxxxxx> wrote:

The PPC4xx GPIO driver stopped assigning an explicit parent
to the gpio_chip when it moved away from of_mm_gpiochip_add_data().

Restore that association from the platform device so OF GPIO lookup
can match phandles to the registered gpiochip.

Tested on: Cisco MX60W. No more probe deferral.

Assisted-by: Codex:GPT-5.5
Fixes: 1044dbaf2a77 ("powerpc/44x: Change GPIO driver to a proper platform driver")
Did I forget to ping someone?

Probably not, but afterwards you sent your series which moves the driver into drivers/gpio/ and which does the same, so this one was flagged "superseeded" in Patchwork (https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260517063754.21819-1-rosenp@xxxxxxxxx/)

I put it back to 'new'. Maddy, can you pick it up ?

Christophe


Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
---
arch/powerpc/platforms/44x/gpio.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/44x/gpio.c b/arch/powerpc/platforms/44x/gpio.c
index aea0d913b59d..4413a94cf7a6 100644
--- a/arch/powerpc/platforms/44x/gpio.c
+++ b/arch/powerpc/platforms/44x/gpio.c
@@ -169,6 +169,7 @@ static int ppc4xx_gpio_probe(struct platform_device *ofdev)

gc = &chip->gc;

+ gc->parent = dev;
gc->base = -1;
gc->ngpio = 32;
gc->direction_input = ppc4xx_gpio_dir_in;
--
2.54.0