Re: [PATCH 04/19] wifi: rtw88: fw: handle the RTL8723BS management TX reports
From: luka . gejak
Date: Thu Jul 30 2026 - 02:12:03 EST
From: Luka Gejak <luka.gejak@xxxxxxxxx>
On 25/07/2026 01:53, Bitterblue Smith wrote:
> This is not right. 0x12 and 0x32 are not C2H IDs, they are the first
> byte of the C2H_CCX_TX_RPT payload.
You are right. Every C2H event this chip sends carries a known id,
0x03 among them, so the existing handler already covers these. The
patch is dropped in v2.
> Since this patch changes the way C2H_WLAN_RFON is handled, it might
> be responsible for some "failed to leave lps" messages? Maybe extending
> the timeout (patch 3/19) is not necessary after all?
It is not. Patch 3 is dropped as well. Instrumenting the report path
shows payload[6] & 0xfc matching the sequence number the driver
enqueued, 32 out of 32 times, with the existing decode.
Best regards,
Luka Gejak