Re: [PATCH v2 4/5] iommu: Add Broadcom BCM2712 IOMMU driver

[Krzysztof Kozlowski]

On Mon, Jul 27, 2026 at 09:43:59PM +0100, Daniel Drake wrote:
> +static int bcm2712_iommu_init_cache(struct bcm2712_iommu *mmu,
> +				    struct platform_device *pdev)
> +{
> +	struct device *dev = &pdev->dev;
> +	struct platform_device *cache_pdev;
> +	struct device_node *cache_np;
> +
> +	cache_np = of_parse_phandle(dev->of_node, "brcm,iommu-cache", 0);
> +
> +	/* Fall back on 'cache' property used in old/downstream firmware */
> +	if (!cache_np)
> +		cache_np = of_parse_phandle(dev->of_node, "cache", 0);

NAK.

You cannot have undocumented ABI. I asked you to drop this at v1.

Best regards,
Krzysztof