Re: [PATCH v4 3/4] zram: validate parameters in each backend's setup_params

[Sergey Senozhatsky]

On (26/07/30 14:01), Haoqin Huang wrote:
> --- a/drivers/block/zram/backend_lz4.c
> +++ b/drivers/block/zram/backend_lz4.c
> @@ -30,6 +30,11 @@ static int lz4_setup_params(struct zcomp_params *params)
>  
>  	if (params->level == ZCOMP_PARAM_NOT_SET)
>  		params->level = LZ4_ACCELERATION_DEFAULT;
> +	else if (params->level < LZ4_ACCELERATION_DEFAULT ||
> +		 params->level > U16_MAX) {

Maybe there should be no upper bound check?  It kind of seems
to me that lz4 doesn't define any clear upper bound.  Or am I
missing something?