Re: [PATCH v6 3/3] arm64: dts: qcom: eliza-evk: Add PCIe1 with TC9563 PCIe switch

[Manivannan Sadhasivam]

On Thu, Jul 30, 2026 at 09:42:29AM +0200, Konrad Dybcio wrote:
> On 7/30/26 7:25 AM, Manivannan Sadhasivam wrote:
> > On Thu, Jul 30, 2026 at 10:18:55AM +0530, Krishna Chaitanya Chundru wrote:
> >> The Eliza EVK board connects PCIe1 (8GT/s x2) to a Toshiba TC9563
> >> PCIe switch. Enable PCIe1 and its QMP PHY nodes.
> >>
> >> TC9563 uses I2C (at address 0x77 on I2C4) for its management interface.
> 
> [...]
> 
> >> +		pcie@3,0 {
> >> +			reg = <0x21800 0x0 0x0 0x0 0x0>;
> >> +			#address-cells = <3>;
> >> +			#size-cells = <2>;
> >> +			device_type = "pci";
> >> +			ranges;
> >> +			bus-range = <0x5 0xff>;
> >> +
> >> +			pcie@0,0 {
> >> +				reg = <0x50000 0x0 0x0 0x0 0x0>;
> >> +				#address-cells = <3>;
> >> +				#size-cells = <2>;
> >> +				device_type = "pci";
> >> +				ranges;
> > 
> > Sashiko pointed out that you are using bridge specific properties in EP node:
> > https://lore.kernel.org/linux-pci/20260730051031.20D8E1F000E9@xxxxxxxxxxxxxxx
> 
> Can we harden the bindings here?
> 

Possible, but overkill IMO. The base dtschema for PCI bridge includes both
'pci-device' and 'pci-bus-common'. So for the Endpoints, we need to restrict
them to use only 'pci-device' schema and that would require adding
'patternProperties' to cover the Endpoint nodes in each binding.

Since this is not a recurring issue, I don't think we really need to go that
far.

- Mani

-- 
மணிவண்ணன் சதாசிவம்