Re: [PATCH bpf-next v2 1/2] bpf, mips: Factor out div/mod emission helpers

[Philippe Mathieu-Daudé]

On 29/7/26 20:54, Nicholas Dudar wrote:
> > This isn't a bug, but would a short header comment on emit_div() and
> > emit_mod(), in the style of the neighbouring '/* ALU register operation
> > (32-bit) */', keep these consistent with the rest of the file? Every
> > other emitter here carries one.
> >
> > Same for emit_div64() and emit_mod64() here.
>
> Agreed that short comments would match the surrounding emitter style.
> I'll add them if the series needs another revision.

Thanks for the v2.

Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxxxxxxxx>