Re: [PATCH 1/2] dt-bindings: clock: qcom: Add Hawi GPU clock controllers

[Krzysztof Kozlowski]

On Sun, Jul 26, 2026 at 10:49:53PM -0700, Dongfang Zhao wrote:
> Add the device tree binding and clock, reset and power-domain IDs for the
> Hawi graphics clock controller. This lets Hawi device trees describe the
> GPU clocks, resets and power domains, and lets dtbs_check validate those
> nodes.
> 
> Add the qcom,hawi-gxclkctl compatible for the Hawi GX clock controller,
> using qcom,kaanapali-gxclkctl as the fallback because the register layout
> is identical.
> 
> Signed-off-by: Dongfang Zhao <dongfang.zhao@xxxxxxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/clock/qcom,hawi-gpucc.yaml | 78 ++++++++++++++++++++++
>  .../bindings/clock/qcom,kaanapali-gxclkctl.yaml    | 22 +++---
>  include/dt-bindings/clock/qcom,hawi-gpucc.h        | 47 +++++++++++++
>  3 files changed, 139 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,hawi-gpucc.yaml b/Documentation/devicetree/bindings/clock/qcom,hawi-gpucc.yaml
> new file mode 100644
> index 000000000000..3ba6e4d212ed
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,hawi-gpucc.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/qcom,hawi-gpucc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Graphics Clock & Reset Controller on Hawi
> +
> +maintainers:
> +  - Dongfang Zhao <dongfang.zhao@xxxxxxxxxxxxxxxx>
> +
> +description: |
> +  Qualcomm graphics clock control module provides the clocks, resets and power
> +  domains on Qualcomm SoCs.
> +
> +  See also: include/dt-bindings/clock/qcom,hawi-gpucc.h
> +
> +properties:
> +  compatible:
> +    const: qcom,hawi-gpucc
> +
> +  clocks:
> +    items:
> +      - description: Board XO source
> +      - description: GPLL0 main branch source
> +      - description: GPLL0 div branch source
> +
> +  power-domains:
> +    items:
> +      - description: A phandle to the CX power-domain
> +      - description: A phandle to the MX power-domain

First MX, then CX, to keep with existing GPUCC.

> +      - description: A phandle to the GMXC power-domain
> +
> +  required-opps:
> +    items:
> +      - description: A phandle to an OPP node describing CX performance points
> +      - description: A phandle to an OPP node describing MX performance points

Same here and: s/A phandle to an OPP node describing//

> +      - description: A phandle to an OPP node describing GMXC performance points
> +
> +required:
> +  - compatible
> +  - clocks
> +  - power-domains
> +  - required-opps
> +  - '#power-domain-cells'

Best regards,
Krzysztof