Re: [PATCH 1/2] dt-bindings: soc: qcom: qcom,pmic-glink: Add compatible string for SM8475

From: Krzysztof Kozlowski

Date: Thu Jul 30 2026 - 05:17:25 EST


On Wed, Jul 29, 2026 at 03:48:24PM -0400, Esteban Urrutia wrote:
> Add compatible string for pmic-glink.

First, not true. You did not add compatible for pmic-glink.

Second, that's redundant. You just repeated subject and the diff
(although incorrectly). Explain why this is not compatible with existing
variants, writing bindings EXPLICITLY ask for that.


Best regards,
Krzysztof