RE: [PATCH v2 09/11] wifi: rtw88: sdio: add TX back-pressure and retry on page starvation

[Ping-Ke Shih]

luka.gejak@xxxxxxxxx <luka.gejak@xxxxxxxxx> wrote:
> On 27/07/2026 09:21, Ping-Ke Shih wrote:
> >> -       queue_work(rtwsdio->txwq, &rtwsdio->tx_handler_data->work);
> >> +       mod_delayed_work(rtwsdio->txwq,
> >> +                        &rtwsdio->tx_handler_data->work, 0);
> >
> > queue_delayed_work()?
> 
> Changed inside the TX handler, where the work is not pending and
> queue_delayed_work() is the right call.
> 
> I kept mod_delayed_work() in rtw_sdio_tx_kick_off() on purpose, because
> there it can race with a pending retry. If a page shortage has already
> armed the work with RTW_SDIO_TX_RETRY_DELAY, queue_delayed_work() would
> see it pending and do nothing, so a newly queued frame would sit for up
> to a millisecond for no reason. mod_delayed_work() re-arms it to fire
> immediately. I have added a comment saying so.

Make sense. Please add a short comment for the reason. 

Ping-Ke