Re: [PATCH] pinctrl: qcom: Remove unused macro definitions

[Konrad Dybcio]

On 7/30/26 11:00 AM, Maulik Shah wrote:
> Remove macros that are defined but never used, as identified by
> -Wunused-macros:
> 
> - pinctrl-qcs8300.c: QUP_I3C_{6,7,13,14}_MODE_OFFSET
> - pinctrl-sa8775p.c: QUP_I3C_{6,7,13,14}_MODE_OFFSET
> - pinctrl-sm6375.c: REG_BASE
> 
> No functional impact.
> 
> Assisted-by: Claude:claude-sonnet-4-6

Switch to sonnet 5!

[...]

> Signed-off-by: Maulik Shah <maulik.shah@xxxxxxxxxxxxxxxx>
> ---
> Remove macros in Qualcomm pinctrl drivers that are defined but never
> used, as identified by -Wunused-macros.
> 
> The QUP_I3C_*_MODE_OFFSET macros in pinctrl-qcs8300.c and
> pinctrl-sa8775p.c, and REG_BASE in pinctrl-sm6375.c have no
> references in their respective files.
> 
> No functional impact.
> ---
You don't need to write a ""cover letter"" for single-patch
submissions, leaving it empty is OK. You can test that with
b4 send -d

Note that if you try to add a single-line ""cover letter"", b4
will trip on that and (likely) treat it as a series topic, which
will be unused (because there's no cover letter)..

[...]

>  
> -#define QUP_I3C_6_MODE_OFFSET	0xaf000
> -#define QUP_I3C_7_MODE_OFFSET	0xb0000
> -#define QUP_I3C_13_MODE_OFFSET	0xb1000
> -#define QUP_I3C_14_MODE_OFFSET	0xb2000

Do we maybe need to use these offsets for something that we don't
support upstream yet?

Konrad