Re: [PATCH v3 1/4] media: qcom: camss: Add PM clock support and integrate with runtime PM

From: Loic Poulain

Date: Thu Jul 30 2026 - 06:03:02 EST


On Thu, Jul 30, 2026 at 11:35 AM Bryan O'Donoghue
<bryan.odonoghue@xxxxxxxxxx> wrote:
>
> On 30/07/2026 10:24, Loic Poulain wrote:
> > + ret = devm_pm_clk_create(dev);
> > + if (ret)
> > + return ret;
>
> !PM_CLK this is an -EINVAL I think.

It is, but we should probably still allow to compile-test the driver
without PM_CLK?
Maybe we should just add a 'depends on PM' since PM_CLK is enabled by
default along PM, and we functionally really want to run our
suspend/resume callback for proper driver behavior.

Regards,
Loic