Re: [PATCH v2 1/4] riscv: defconfig: enable RFKILL and RFKILL_GPIO

[Aurelien Jarno]

Hi, Anirudh,

On 2026-07-29 12:30, Anirudh Srinivasan wrote:
> Hi Aurelien,
> 
> On Wed, Jul 29, 2026 at 12:24 PM Aurelien Jarno <aurelien@xxxxxxxxxxx> wrote:
> >
> > The SpacemiT K3 Pico-ITX requires RFKILL_GPIO to enable bluetooth and
> > wlan.
> >
> > Tested-by: Anirudh Srinivasan <asrinivasan@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Aurelien Jarno <aurelien@xxxxxxxxxxx>
> > ---
> >  arch/riscv/configs/defconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> > index 74ba5acc12a40..8668aa31e79aa 100644
> > --- a/arch/riscv/configs/defconfig
> > +++ b/arch/riscv/configs/defconfig
> > @@ -99,6 +99,8 @@ CONFIG_NET_CLS_CGROUP=m
> >  CONFIG_NETLINK_DIAG=y
> >  CONFIG_CGROUP_NET_PRIO=y
> >  CONFIG_CAN=m
> > +CONFIG_RFKILL=m
> > +CONFIG_RFKILL_GPIO=m
> >  CONFIG_NET_9P=y
> >  CONFIG_NET_9P_VIRTIO=y
> >  CONFIG_PCI=y
> 
> The riscv defconfig doesn't have CONFIG_RTW89=m and
> CONFIG_RTW89_8852BE in it. Do we need to add it?

That's a good point, not sure to which level we need to enable all 
modules of supported hardware. I added RFKILL and RFKILL_GPIO as it was 
not obvious to me that those need to be enabled to get proper WiFi 
support. Also those are tiny drivers compared to the RTW89 driver.
OTOH, I see that this driver is enabled for the loongarch architecture, 
so maybe we can do the same for riscv..

Paul, any idea about that, any policy?

> I was testing with a distro defconfig, so didn't need to add it
> manually. I should have realized this sooner.

Yes same, so I also didn't notice.

Regards
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@xxxxxxxxxxx                     http://aurel32.net