Re: [PATCH 3/6] ptp: qcom: Add PTP driver for the Qualcomm TSC hardware

[Imran Shaik]

On 28-07-2026 04:50 am, Jakub Kicinski wrote:
> On Mon, 27 Jul 2026 19:40:59 +0530 Imran Shaik wrote:
> > +static inline void qcom_tsc_split_ts(struct qcom_tsc *tsc, struct timespec64 ts, u32 *hi, u32 *lo)
> > +{
> > +	if (tsc->soc->rollover) {
> > +		*hi = ts.tv_sec;
> > +		*lo = ts.tv_nsec;
> > +	} else {
> > +		u64 ns = timespec64_to_ns(&ts);
> > +
> > +		*lo = lower_32_bits(ns);
> > +		*hi = upper_32_bits(ns);
> > +	}
> > +}
>
> Are you sure the compiler doesn't inline this trivial function with 2
> callers even without the inline keyword. Compilers seem to inline as
> much as possible these days.

Sure, will drop the inline keyword in the next series.

Thanks,
Imran