Re: [PATCH v2 1/2] IB/isert: delay the final Login Response until the session is registered

[Yehyeong Lee]

Sashiko flagged two things on this v2, so please do not apply it as it
stands.

1/2 leaks the login_tx_desc DMA mapping when the connection is torn down
before isert_get_rx_pdu() posts the delayed response.  Nothing unmaps it:
isert_login_send_done() never runs, and isert_connect_release() does not
touch login_tx_desc.dma_addr.

2/2 reads isert_conn->state with READ_ONCE() in isert_recv_done().  A
control dependency does not order the loads that follow, so the se_tpg
dereference in isert_rx_opcode() can be hoisted ahead of the check; it
needs smp_load_acquire().

I will send v3 with both, and with the error path logging the value it
actually tested.

Best regards,
Yehyeong